add action to a SettingToggle control #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aheze This PR by @mehdin13 implements both #37 and also EDIT: Upon further review, it seems this PR, and probably the one in #37 are both broken - at least when comparing rendered results against #19 specifically regarding #12. See below screenshot for what I mean (Icon misalignment).
|
This was referenced Jan 26, 2025
duraki
added a commit
to When-original-devs-wont-merge-good-PRs/Setting
that referenced
this pull request
Jan 26, 2025
…sue via nillable horizontalPadding _ref aheze#42 This update fixes SettingToggle implementing Icons among other functionality (ref. aheze#42) - impl: edgePadding setter (optional) via env_var, otherwise uses horizontalPadding (default) - fixes: Icon padding issue (ref via nillable horizontalPadding (ref. [aheze/Setting/#2614139662](aheze#38 (comment))), covering aheze#38, aheze#37 - impl: SettingToggle extension supporting `.icon(...)` methods
duraki
added a commit
to When-original-devs-wont-merge-good-PRs/Setting
that referenced
this pull request
Jan 26, 2025
…sue via nillable horizontalPadding _ref aheze#42 This update fixes SettingToggle implementing Icons among other functionality - impl: edgePadding setter (optional) via env_var, otherwise uses horizontalPadding (default) - fixes: Icon padding issue (ref via nillable horizontalPadding (ref. aheze#38 (comment), covers aheze#38, aheze#37 - impl: SettingToggle extension supporting `.icon(...)` methods - impl: SettingToggle `onChange(...)` event handler, triggering when toggle is switched on/off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.