Skip to content

feat(HITL): Emit UserConfirmResultEvent when resuming permission HITL - #2511

Draft
jujn wants to merge 1 commit into
mainfrom
emit-user-confirm-result-event
Draft

feat(HITL): Emit UserConfirmResultEvent when resuming permission HITL#2511
jujn wants to merge 1 commit into
mainfrom
emit-user-confirm-result-event

Conversation

@jujn

@jujn jujn commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Emit UserConfirmResultEvent when ReActAgent accepts ConfirmResult payloads while resuming permission HITL.
  • Persist the pending confirmation request replyId on the live assistant message so the result event can correlate with the earlier RequireUserConfirmEvent.
  • Validate that resume ConfirmResults fully cover all current ASKING tool calls before emitting the event or mutating context.
  • Update HITL tests and event docs for the new resume-event behavior.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with mvn spotless:apply
  • All tests are passing (mvn test)
  • Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

Copilot AI review requested due to automatic review settings July 31, 2026 12:36
@gemini-code-assist

Copy link
Copy Markdown

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 69.69697% with 20 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...e/src/main/java/io/agentscope/core/ReActAgent.java 69.23% 9 Missing and 11 partials ⚠️

📢 Thoughts on this report? Let us know!

@jujn
jujn marked this pull request as draft July 31, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants