fix(skills): stop claiming -f/-v are universal in webcmd-usage - #402
Open
Agnik47 wants to merge 1 commit into
Open
fix(skills): stop claiming -f/-v are universal in webcmd-usage#402Agnik47 wants to merge 1 commit into
Agnik47 wants to merge 1 commit into
Conversation
The webcmd-usage skill labeled -f/--format and -v/--verbose as universal flags, but neither is: -v is absent from most plugin/profile/session/adapter/daemon built-ins, and -f is absent from every pure-action built-in (plugin install/update, adapter override, profile create/rename/use, daemon restart/stop, browser init). Replace "Universal Flags" with "Format and Verbose Flags", state support is command-specific, and add a breakdown table of exactly which built-ins take each flag. Point agents at `<command> --help` as the authoritative check instead of a table that goes stale. Closes agentrhq#173. Verified locally: - ran --help on ~24 affected commands and confirmed every table entry against actual flag output - npx vitest run --project unit src/skills.test.ts src/docs-sync-review.test.ts src/hosted/manifest.test.ts (76 pass) - diffed skill-src/webcmd-usage/SKILL.src.md against the generated skills/webcmd-usage/SKILL.md to keep both in sync
Contributor
🟢 No documentation gap found — medium confidenceThe automated review found no documentation gap in the supplied changes. This review is advisory and does not block merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
webcmd-usageskill's "Universal Flags" section claimed-f/--formatand
-v/--verbosework everywhere. Neither does:-vis missing from mostplugin/profile/session/adapter/daemonbuilt-ins
-fis missing from every pure-action built-in (plugin install/update,adapter override,profile create/rename/use,daemon restart/stop,browser init)The original issue's specific examples (e.g.
browser network --format json)no longer exist in the command surface, but the underlying claim of
universality is still wrong and worse than the issue described.
Fix
Replace "Universal Flags" with "Format and Verbose Flags": state that support
is command-specific, add a breakdown table of exactly which built-ins take
each flag, and point agents at
<command> --helpas the authoritative checkrather than a table that will go stale as commands change.
Edited both
skill-src/webcmd-usage/SKILL.src.mdand the generatedskills/webcmd-usage/SKILL.md(identical change — this file has no@[...]imports in the edited region, so the generator is an identitytransform here).
Closes #173.
Verification
--helpon ~24 affected commands (list,validate,skills,plugin search,browser verify,session create/list/close,profile list,auth status/refresh,doctor,web fetch,browser tabs/run/bind/snapshot/close,plugin install/update,browser init,profile create/rename/use,daemon restart/stop,adapter override) and confirmed every table entry against the actualflag output.
npx vitest run --project unit src/skills.test.ts src/docs-sync-review.test.ts src/hosted/manifest.test.ts— 76 pass.SKILL.src.mdagainst generatedSKILL.mdto confirm they match.