Fix Reddit popular HTML response handling#17
Open
ankitranjan7 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reddit popularexplicitly navigate tohttps://www.reddit.combefore fetching/r/popular.jsonUnexpected token <Verification
npm run test:adapter -- clis/reddit/popular.test.jsnpm run dev -- reddit popular --limit 3 -f jsonnpm run test:adapter -- clis/reddit/*.test.jsnpm run check:typed-error-lintnpm run check:silent-column-dropnpm run typechecknpm run buildReddit smoke checks
Read-only live commands verified:
reddit popular --limit 2reddit frontpage --limit 2reddit hot --limit 2reddit subreddit programming --limit 2reddit search "web development" --limit 2reddit subreddit-info programmingreddit user spezreddit user-posts spez --limit 2reddit user-comments spez --limit 2reddit read 1um1euf --limit 2Auth-bound commands were not live-verified because the browser session is not logged in. Write commands were help-checked only to avoid mutating a real Reddit account.