feat(ui-tui): say where the link hover indicator lives in help rows#704
Merged
Merged
Conversation
Follow-up to #701 from user feedback ("the user needs to know the link is clickable"): the hover affordance exists, but nothing said so. - OSC 8 terminals row: "(Cmd/Ctrl+hover underlines it)" — the terminal's own native hover indicator (VS Code/iTerm2/kitty...). - Fullscreen row: "(highlights on hover)" — the renderer's own hover overlay (applyHyperlinkHoverHighlight inverts the link's cells), verified live by injecting SGR mouse-motion events in a PTY e2e. No modifier-gated variant is possible: terminals don't encode the Cmd key in SGR mouse reports, and inline mode receives no mouse events at all (Apple Terminal inline can't have a hover indicator, full stop). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Test Results 1 files 1 suites 7m 38s ⏱️ For more details on these failures, see this check. Results for commit eafaf83. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #701, from user feedback: "add a mouse-over indicator when holding Command over a link — the user needs to know the link is clickable."
Investigation showed the indicator already exists everywhere it's physically possible; what was missing is anything telling the user. This PR makes the
?//helplink rows say where the hover affordance lives:Cmd+click link — open link in browser (Cmd+hover underlines it)(the terminal's native indicator; Ctrl on non-mac).click link — open link in browser (highlights on hover)— the renderer's own hover overlay (applyHyperlinkHoverHighlightinverts the link's cells under the pointer), verified end-to-end by injecting SGR mouse-motion events in a PTY e2e (cells flip to inverse on hover, clear on leave; DEC 1003 armed).A Cmd-gated indicator is unimplementable in-app: SGR mouse reports encode only shift/alt/ctrl — macOS terminals never forward the Cmd key — and inline mode deliberately never captures the mouse at all.
Verification
reverse=True, cleared on pointer leave.🤖 Generated with Claude Code