Repository navigation
Add parked charge current and departure preconditioning - #23
Merged
Merged
Conversation
charge-amps sends the upstream charging-set-amps command. departure show, set, and remove use precondition-schedule-add and precondition-schedule-remove. A show does not wake the car. Changes need a confirmation and cannot be scheduled.
departure set can omit latitude and longitude and read the car's current location. where --precise prints that point and a map link without waking the car. History still stores no coordinates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
charge-amps <amps>sets the charging current through upstreamtesla-control charging-set-amps(set_charging_amps). The value is a whole number from 1 to 80. The car may clamp it to what the charger allows. The confirmation isI confirm charging set amps.departure showreadspreconditioning_schedule_dataand does not wake a sleeping car.departure setsignsprecondition-schedule-add(add_precondition_schedule). The confirmation isI confirm departure schedule set. Latitude and longitude are optional. Pass both, or omit both to use the car's current precise location fromlocation_data. That read happens after the same wake other parked changes use. If the location read says the car is asleep, it is not woken again.departure removesignsprecondition-schedule-removewith typeid. The confirmation isI confirm departure schedule remove.wherestays a non-waking coarse area.where --preciseprints latitude, longitude, and an OpenStreetMap link when the car is already online, and it still does not wake the car.set_scheduled_departurecommand is not sent. Park and speed 0 still apply to the changes. A schedule cannot run them.check,report,where, and history still do not wake a sleeping car.preconditionstays immediateclimate-on.Test plan
pytest -q(201 passed)location_dataafter the write wake, and a 408 on that read is not followed by another wakewhere --preciseprints the point and a map link, does not wake, and does not call Nominatim