Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/a2a-handshake-return-reply-nonce.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@agentcommercekit/ack-id": patch
---

Return the freshly generated `replyNonce` from `createA2AHandshakeMessage` when responding to a handshake, so callers can correlate the next leg.
15 changes: 15 additions & 0 deletions packages/ack-id/src/a2a/sign-message.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,4 +149,19 @@ describe("createA2AHandshakeMessage", () => {
expect.objectContaining({ kind: "data", data: { jwt: result.sig } }),
)
})

it("returns the fresh replyNonce when requestNonce is provided", async () => {
const result = await createA2AHandshakeMessage(
"agent",
{
recipient: userDid,
vc: testCredential,
requestNonce: "initiator-nonce",
},
{ did: agentDid, jwtSigner },
)

expect(result.nonce).toBe("test-nonce-1234")
expect(result.nonce).not.toBe("initiator-nonce")
})
})
4 changes: 3 additions & 1 deletion packages/ack-id/src/a2a/sign-message.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,9 @@ export async function createA2AHandshakeMessage(
return {
sig: jwt,
jti,
nonce: payload.nonce,
// When replying, callers need the freshly generated replyNonce for the next
// handshake leg — not the peer's original request nonce in payload.nonce.
nonce: payload.replyNonce ?? payload.nonce,
message,
}
}
Expand Down