Skip to content

feat: expose configured permission profiles as modes - #395

Open
tpansino wants to merge 1 commit into
agentclientprotocol:mainfrom
tpansino:feat/permission-profile-modes
Open

feat: expose configured permission profiles as modes#395
tpansino wants to merge 1 commit into
agentclientprotocol:mainfrom
tpansino:feat/permission-profile-modes

Conversation

@tpansino

Copy link
Copy Markdown

Summary

  • List allowed, user-defined Codex permission profiles using permissionProfile/list
  • Expose those profiles in ACP mode selectors, including their configured descriptions
  • Restore the active profile when starting or resuming a session
  • Send named profiles through turn/start without combining them with legacy sandbox policies
  • Preserve additional workspace roots and the effective approval policy
  • Keep the existing read-only, agent, and full-access modes unchanged

Built-in and disallowed profiles are omitted from the additional profile entries.

Related to #310.

PR #357 maps the existing fixed ACP modes to configured profiles. This change instead discovers allowed custom profiles dynamically and exposes them as selectable ACP modes.

Testing

  • npm run typecheck
  • npm test — 404 passed, 28 skipped
  • npm run build
  • Native macOS ARM bundle
  • Real Codex 0.147 app-server profile discovery and selection
  • End-to-end Zed test with a custom permission profile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant