Skip to content

fix: explicitly pass model provider on session resume #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexandrSuhinin merged 1 commit into from
May 7, 2026
+8 −2
Merged

fix: explicitly pass model provider on session resume #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/CodexAcpClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ export class CodexAcpClient {
cwd: request.cwd,
developerInstructions: null,
model: null,
modelProvider: this.getModelProvider(),
modelProvider: this.getResumeModelProvider(),
personality: null,
threadId: request.sessionId,
});
Expand All @@ -232,7 +232,7 @@ export class CodexAcpClient {
cwd: request.cwd,
developerInstructions: null,
model: null,
modelProvider: this.getModelProvider(),
modelProvider: this.getResumeModelProvider(),
personality: null,
threadId: request.sessionId,
});
Expand Down Expand Up @@ -304,6 +304,12 @@ export class CodexAcpClient {
return this.gatewayConfig?.modelProvider ?? this.modelProvider;
}

private getResumeModelProvider(): string {
// Passing `null` forces codex to use the persisted provider for resumed session instead of default one
// Explicit fallback to "openai" fixes error `Model provider not found` at least for ChatGPT authentication
return this.getModelProvider() ?? "openai";
}

private async refreshSkills(cwd: string, meta?: Record<string, unknown> | null): Promise<void> {
if (!cwd) {
return;
Expand Down
Loading