Conversation
benbrandt
reviewed
May 7, 2026
|
|
||
| ### Plan Removal | ||
|
|
||
| Agent sends a `plan_removed` session update with the plan's `id` to dismiss it. This is a separate session update type from `plan_update`, keeping content updates and lifecycle events distinct. |
Member
There was a problem hiding this comment.
I wonder if there is a way to null out the content like we do in some other areas rather than have another notification type?
Just a thought.
| | ---------- | ----------------------------------------------------- | ---------------------- | | ||
| | `items` | Structured entries (same semantics as today's `plan`) | `entries: PlanEntry[]` | | ||
| | `file` | Agent provides a file URI containing the plan | `uri: string` | | ||
| | `markdown` | Agent provides raw markdown text | `content: string` | |
Member
There was a problem hiding this comment.
Can add this later, but is there a need for a label/description for some of these types?
| "type": "items", | ||
| "id": "plan-1", | ||
| "entries": [ | ||
| { "content": "Step 1", "priority": "high", "status": "pending" } |
Member
There was a problem hiding this comment.
What is the expectation of the client?
If I get multiple items updates, am I expected to render them all until they are removed?
And I assume the plan is "completed" not by being removed, but by all items being marked as done?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.