ateom-microvm: start the actor's two virtiofsds concurrently - #969
Open
Benjamin Elder (BenTheElder) wants to merge 1 commit into
Open
ateom-microvm: start the actor's two virtiofsds concurrently#969Benjamin Elder (BenTheElder) wants to merge 1 commit into
Benjamin Elder (BenTheElder) wants to merge 1 commit into
Conversation
An actor with durable-dir volumes runs two virtiofsds: the overlay RO lower's share and the writable durable share. They are independent — different shared dirs, different sockets — but cold boot and restore staged them in sequence, and starting one blocks until its virtiofsd binds, so both boot paths paid the two waits back to back. Start them together in stageActorShares. With the socket poll already down to a millisecond tick (agent-substrate#849), the pair now costs roughly one wait. The errgroup deliberately carries no shared context: a failure on one side must not cancel the other's mount subprocesses mid-flight. Whatever did come up is killed before returning the error, so the caller owns the processes only on success — same contract the two separate defers had.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
~no impact if no durabledirs are used, but saves some time if they are