atelet checkpoint idempotency - #948
Draft
Troy Chiu (troychiu) wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #372
Makes
Checkpointsafe to replay. Today a lost response (an atelet restart,a deadline exceeded mid-call) leaves the caller unable to tell "never
started" from "finished, and the answer went missing" — and retrying drives
the sandbox runtime against state the first attempt destroyed, which is the
runsc fscheckpoint … exit status 128in the issue.manifest.jsonbefore doinganything and returns success when it is there. The manifest is a
trustworthy commit marker because both persist paths write it last, and
the control plane mints the destination once per suspend/pause, so a
manifest there names this checkpoint and no other.
moveLocalCheckpointbecomes resumable to match: a rename is not repeatable, so a file already
at the destination is recognized as this checkpoint's own earlier work.
files are written, and replays it instead of re-running the checkpoint.
A failure with the sandbox confirmed gone is now reported as
DataLosswith the actor-crash directive, so the control plane records unrecoverable
state instead of an opaque runtime exit status.
RunandRestoreneed a per-activation idempotency key (actor UID isstable across activations) and follow in a second PR.