fix(hack): let teardown delete crashed actors - #942
Open
NekoPunch (orangeCatDeveloper) wants to merge 1 commit into
Open
fix(hack): let teardown delete crashed actors#942NekoPunch (orangeCatDeveloper) wants to merge 1 commit into
NekoPunch (orangeCatDeveloper) wants to merge 1 commit into
Conversation
--delete-all aborted on the first STATUS_CRASHED actor, leaving the ActorTemplate behind; the redeploy then failed on the immutable spec and kept serving the previous golden snapshot. DeleteActor already accepts CRASHED, so teardown can delete those directly. Demo handlers also ran from an `if` condition, which suppresses errexit for their whole call tree and turned any failed deploy into exit 0. They now run as plain commands and report an unclaimed flag through ate_demo_flag_unhandled.
NekoPunch (orangeCatDeveloper)
force-pushed
the
issue-794-teardown-crashed-actors
branch
from
August 14, 2026 10:26
40c7936 to
e869172
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #794
A crashed actor makes
--delete-allabort mid-teardown, leaving the ActorTemplate behind; the next--deploy-demo-counteris then rejected on the immutable spec and the cluster keeps serving the stale golden snapshot.prepare_actor_for_deletetreatsSTATUS_CRASHEDas unexpected and returns 1, which errexit turns into a hard abort — even though DeleteActor accepts CRASHED (workflow_delete.go). Teardown now treats crashed actors as deletable as-is.The demo flag dispatch had the mirror-image defect: handlers ran from an
ifcondition, which suppresses errexit for their whole call tree, so this same teardown — and failed deploys like the issue's immutable-spec apply — exited 0. Handlers now run as plain commands and report an unclaimed flag throughate_demo_flag_unhandled.Before (main, actor in
STATUS_CRASHED):After (this branch, same state):
Repro: deploy the counter demo, resume an actor, delete its worker pod (~20s later the syncer marks it
STATUS_CRASHED), run--delete-all.