Skip to content

e2e: note that not every failed suite retains a namespace #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Yuan Gao (ygao-g) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

e2e: note that not every failed suite retains a namespace #924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions internal/e2e/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,16 @@ of running pods, so clean up once you are done reading:
$ hack/cleanup-e2e.sh # deletes every namespace labeled ate.dev/e2e
```

Not every suite has a namespace to keep. One that runs against a pre-installed
worker pool -- `TestActorEgress` uses the standing `ate-demo-egress` pool from
`hack/install-ate-kind.sh --deploy-demo-egress` -- creates only an atespace,
which lives in Valkey rather than Kubernetes, so a failure leaves nothing
labeled `ate.dev/e2e` behind. Read the standing namespace instead:

```shell
$ kubectl logs -n ate-demo-egress -l ate.dev/worker-pool=egress
```

## Creating a new test suite

Copy `testmain_test.go` from `internal/e2e/suites/example` into your new suite. It will
Expand Down
Loading