split controlapi functional tests into their own package - #918
Open
Luiz Oliveira (laoj2) wants to merge 1 commit into
Open
split controlapi functional tests into their own package#918Luiz Oliveira (laoj2) wants to merge 1 commit into
Luiz Oliveira (laoj2) wants to merge 1 commit into
Conversation
Collaborator
|
Needs rebase |
Luiz Oliveira (laoj2)
force-pushed
the
split-functional-tests
branch
3 times, most recently
from
August 14, 2026 13:09
b7c772c to
b13a339
Compare
Collaborator
Author
|
CI was failing because tests were broken at HEAD. Rebased, so this should be good to be reviewed again now. |
2 tasks
Luiz Oliveira (laoj2)
added a commit
to laoj2/substrate
that referenced
this pull request
Aug 14, 2026
RunContractTests is getting large and resource tests are not always grouped together. So, let's start with splitting them into separate functions. As they grow, we may consider moving them to their own files, like we did for functional tests in agent-substrate#918
Luiz Oliveira (laoj2)
force-pushed
the
split-functional-tests
branch
from
August 14, 2026 18:59
b13a339 to
8b424ae
Compare
functional_test.go was also split into one file per resource, to match what we're doing for the RPC handlers too. See agent-substrate#891 I also needed to make some changes to move the tests to a separate package: * `NewAteletDialer` now takes `options`, and `WithDialCredentials` lets a test build its own transport credentials. The fake atelet is reached over insecure transport. Didn't change existing callers. This is the only non-test change.
Luiz Oliveira (laoj2)
force-pushed
the
split-functional-tests
branch
from
August 14, 2026 19:10
8b424ae to
eb26cc2
Compare
Julian Gutierrez Oschmann (juli4n)
pushed a commit
that referenced
this pull request
Aug 14, 2026
RunContractTests is getting large and resource tests are not always grouped together. So, let's start with splitting them into separate functions. As they grow, we may consider moving them to their own files, like we did for functional tests in #918 > It's a good idea to open an issue first for discussion. - [x] Tests pass - [ ] Appropriate changes to documentation are included in the PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
functional_test.go was also split into one file per resource, to match what we're doing for the RPC handlers too. See #891
I also needed to make some changes to move the tests to a separate package:
NewAteletDialernow takesoptions, andWithDialCredentialslets a test build its own transport credentials. The fake atelet is reached over insecure transport. Didn't change existing callers. This is the only non-test change.Fixes #891