fix: correct errors in docs#322
Open
Mesut Oezdil (mesutoezdil) wants to merge 1 commit into
Open
Conversation
…y command, and CoC link
| ## Attribution | ||
|
|
||
| This Code of Conduct is adapted from the Contributor Covenant, version 1.4, | ||
| This Code of Conduct is adapted from the Contributor Covenant, version 2.1, |
Collaborator
There was a problem hiding this comment.
This is not really a bug is it? cc Tim Hockin (@thockin)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/observability.md: log label keys were wrong. The code emitsate.dev/actor_idandate.dev/actor_template_name; the doc hadactor_idandactor_template. The Cloud Logging queries would return no results.docs/dev/best-practices/tracing.md: container ports entry used Docker Compose syntax ("443:443"). Changed tocontainerPort: 443.docs/dev/valkey-direct-access.md: thekubectl execcommand had a line break inside--cert, making it fail on copy-paste.code-of-conduct.md: linked to Contributor Covenant v1.4. Updated to v2.1.