hack/update/licenses.sh: mirror in-tree third_party licenses#291
Merged
Bowei Du (bowei) merged 1 commit intoJun 23, 2026
Merged
Conversation
go-licenses only covers module dependencies and treats our own module — including any copied-in / forked third-party SOURCE under in-tree third_party/ dirs — as first-party, so those upstream LICENSE/NOTICE/ COPYING files are never collected. Mirror them into LICENSES/third_party/, keyed by their path under third_party/, the same way kubernetes' hack/update-vendor-licenses.sh does. `git ls-files` is used so gitignored paths are skipped; vendor/ and the output dir are excluded since they hold module deps / generated output rather than forked source. This is a no-op today (there is no in-tree third_party source yet) and prepares the licenses tooling for forthcoming vendored third-party code.
Merged
2 tasks
Davanum Srinivas (dims)
approved these changes
Jun 23, 2026
Bowei Du (bowei)
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-licenses only covers module dependencies and treats our own module — including any copied-in / forked third-party SOURCE under in-tree third_party/ dirs — as first-party, so those upstream LICENSE/NOTICE/COPYING files are never collected.
Mirror them into
LICENSES/third_party/, keyed by their path under third_party/, the same way kubernetes'hack/update-vendor-licenses.shdoes.git ls-filesis used so gitignored paths are skipped;vendor/and the output dir are excluded since they hold module deps / generated output rather than forked source.This is a no-op today (there is no in-tree third_party source yet) and prepares the licenses tooling for forthcoming vendored third-party code.
Pulled out from #287