ateom-gvisor: tag forwarded actor logs with ate.dev/container_name#290
Merged
Julian Gutierrez Oschmann (juli4n) merged 1 commit intoJun 23, 2026
Conversation
Davanum Srinivas (dims)
approved these changes
Jun 23, 2026
Collaborator
Author
|
NOTE: multi-container works fine on gVisor, and we have some demos with this. It's just all the container logs were impossible to distinguish previously. |
Give each application container its own JSON log pipe (instead of multiplexing every container onto one), and add a containerName argument to WrapContainerLogs/StartJSONLogPipe that sets an ate.dev/container_name label. Multi-container actors logs can now be demultiplexed by container.
Benjamin Elder (BenTheElder)
force-pushed
the
gvisor-container-name
branch
from
e9054d2 to
392e74c
Compare
Julian Gutierrez Oschmann (juli4n)
approved these changes
Jun 23, 2026
Julian Gutierrez Oschmann (juli4n)
merged commit f5df01b
into
agent-substrate:main
9 checks passed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on multi-container support for uVM in #287 I noticed how difficult it is to debug multi-container workloads.
This makes it a lot easier. TODO: We could support filtering on this in kubectl ate (cc Haven Xia (@HavenXia))