Repository navigation
Publish npm through shared publish-native-npm; delete bespoke packaging (PLAT-1012) - #153
Conversation
Replace the bespoke npm packaging (quire-dist package-npm/verify-published, set-version/verify-release, the Node launcher npm/quire-cli) with agent-ix/nodejs-actions/publish-native-npm (static-musl). Keep quire-dist verify-binary. Supersede FR-022/023/024, NFR-008, US-007 and ADR-0002 (new ADR-0003) and their test rows. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
kreneskyp
left a comment
There was a problem hiding this comment.
Lead review (diff only): PLAT-1012. release.yml npm half replaced by one agent-ix/nodejs-actions/publish-native-npm@main step (static-musl, self-update-command update, id-token OIDC, NPM_TOKEN bootstrap fallback kept, publish gated by inputs.publish) plus a retrying post-publish smoke modelled on quoin's. Deletes npm/ (launcher), quire-dist package-npm/verify-published/set-version/verify-release and their tests/probe, Makefile dist-package/dist-verify/dist-verify-published/set-version, the local npm.ix README section (its commands are gone), FR-023/FR-024/NFR-008. Spec: FR-022 and US-007 rewritten to keep the user-visible install requirement; ADR-0002 superseded by ADR-0003; FR-025 CON-4/5 and TC-839 now say the repo owns no JS; only packaging-describing rows removed. No new behavior. Gate: fmt-check and lint green; tests green except it_144 (host lacks python jsonschema); make spec: validate passes, assurance-traceability UntrackedSymbols=4 identical on unmodified main. NOT verifiable from here: the action step and a publish:false dry run via workflow_dispatch, that the existing npm Trusted Publisher still matches release.yml, the exact quire update stderr the smoke greps. Run the dry run before the next release. No findings.
PLAT-1012. Publishes
@agent-ix/quire-clithroughagent-ix/nodejs-actions/publish-native-npm@main(withstatic-musl: "true", nodejs-actions#13) and deletes the bespoke duplicate.Deleted
npm/(launcherbin/quire.js,package.json, README,.gitignore)package-npm,verify-published,set-version,verify-release,quire-dist-probe, testsdistribution.rs,npm_host.rs,policy.rs(kept:verify-binary, with a small new test); depsserde_json/toml_editdroppeddist-verify,dist-package,dist-verify-published,set-versionverify-binaryrelease.yml
npm half replaced by one action step plus a post-publish smoke (install,
--version,quire updatedefers to npm), as in quoin. GitHub Release and binary version assertion unchanged. No behavior added.Gate
make fmt-checkandmake lintpass.cargo test --workspace --locked --all-targets --all-features --no-fail-fast: onlyit_144fails (python jsonschema missing on this host).make spec:UntrackedSymbols { count: 4 }, identical on origin/main (4cli_coverage_stricttests).Not verified (needs a workflow run)
The action step, OIDC publish, the
publish: falsedry run, the post-publish smoke, and that the existing npm trusted publisher still matchesrelease.yml. Nothing was tagged, published or dispatched.🤖 Generated with Claude Code