Repository navigation
trace/coverage: shared trace-id fold, scoped module discovery (PLAT-898, 908, 179) - #151
Merged
Merged
Conversation
…ery in coverage - PLAT-898: adopt quire-rs 0.53.0 and use its exported trace_id_segments; delete the CLI's duplicate id_segments fold. - PLAT-908: document the --prefix / --id separator-count divergence, pin it with a known-divergence test, and make matched_ids cover every id the payload returns. - PLAT-179: coverage (and trace/symbols via load_registry_for) now use the same scoped discovery as validate, including <scope>/.ix/modules. - validate: handle the new ValidationReason::Regex in validation_remedy. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
kreneskyp
commented
Nov 8, 2026
kreneskyp
left a comment
kreneskyp
left a comment
Contributor
Author
There was a problem hiding this comment.
Lead review (diff only): PLAT-898 trace.rs now uses quire_rs::symbols::trace::trace_id_segments and drops the duplicate fold; PLAT-908 corrects the false fold-agreement doc, adds matched_ids for every payload id and pins the known separator divergence; PLAT-179 coverage::load_registry_for now uses scoped discovery with defaults (shared with trace/symbols), test fails on old code (SearchPathMissing) and passes on new. main merged in with plain merge; duplicate Regex remedy arm removed. Gate: fmt-check and lint clean; tests green except it_144 (host lacks python jsonschema, not this change). make ci not run. No findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts quire-rs 0.53.0 (same pin and Cargo.lock as #150) and fixes three tickets.
quire trace --prefixcalls the exportedtrace_id_segments; the duplicateid_segmentsis deleted.--prefixand--id, pins it withprefix_known_divergence_for_ids_without_a_separator, andmatched_idsnow covers every id in the payload.coverage(andtrace/symbols, which shareload_registry_for) discover modules likevalidate, including<scope>/.ix/modules. Regression testplat179_*fails on main, passes here.validate.rs: adds theValidationReason::Regexarm required by 0.53.0. validate: pass repo bundle package; adopt quire-rs 0.53.0 (PLAT-50) #150 also touches validate.rs, so expect a small merge there; the Cargo hunks are identical.PLAT-315, 70, 251, 178 were verified already done on main; no changes here.
Gate: fmt-check, lint clean; cargo test --workspace: all pass except it_144 (host lacks python jsonschema).
🤖 Generated with Claude Code