Repository navigation
Explain refused and partially read trace tags in matrix (PLAT-1150) - #124
Merged
Merged
Conversation
…x diagnostics to ix-cli-kit Record API Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
kreneskyp
marked this pull request as ready for review
November 8, 2026 16:58
kreneskyp
commented
Nov 8, 2026
kreneskyp
left a comment
Contributor
Author
There was a problem hiding this comment.
Lead review (diff only): PLAT-1150 quire matrix now sends engine diagnostics and unmatched trace tags to stderr (structured under JSON diagnostics) with stdout payload and strict verdict unchanged. After merging current main: FR-026-AC-15 collision resolved by renumbering this criterion to FR-026-AC-16; matrix.rs ported to the ix-cli-kit Record/DiagnosticFields stream types after #131. Gate: fmt-check and lint clean; tests green except it_144 (host lacks python jsonschema, not this change). No findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quire matrixsilently discarded the engine's explanations of source-tag ranges and IDs outside the declared trace grammar. At quire-driver e7f6e89, ranges already producerange-in-trace-tagand IDs dropped afterandalready appear inunmatched_tags; selecting only coverage_matrix hid both.Emit those existing engine facts as warnings on stderr in markdown, JSON and TSV. JSON diagnostics retain reason, path and line. Stdout matrix data, binding semantics and strict verdict stay unchanged. Source ranges remain forbidden by FR-050-AC-50/FR-051-AC-28; Trace lists continue to use the module-declared comma grammar. FR-026-AC-15 documents the behavior.
Validation: pre-fix regression fails; Rust/Python/TypeScript cases pass in every format, typed warning checks retain locations, and comma-list healthy controls restore strict success with no tag warnings. Full local workspace suite passes 279 tests (one deliberately ignored network test); lint and formatting pass. The real driver checkout's JSON matrix is byte-identical before/after, while stderr now names the six dropped quire-cache IDs and the forbidden ranges. Includes the one-line Linux-only unused-mut correction independently verified by PLAT-1149's green Linux CI.
Tracking: https://linear.app/agent-ix/issue/PLAT-1150. This PR changes no engine pin and is independent of PLAT-1149's fix stack.