Repository navigation
Ragdoll solver state for late joins (#189), head, clavicle, hand and spine bodies and twisting hinges (#190), Aether 0.919.0 - #191
Open
nicolas-maman wants to merge 2 commits into
Open
nicolas-maman wants to merge 2 commits into
nicolas-maman wants to merge 2 commits into
Conversation
Every module, test, benchmark and example checks and runs clean on 0.919.0 with no source change, the golden trace bit for bit.
…and knees that twist (#190) Each is a flag on Human beside `ankles`, set before the figure is made, at fixed bone indices (BONE_HEAD 14 to BONE_SPINE_02 19, MAX_BONE_COUNT 20); a slot not asked for has no body (human_has_bone). Every flag off, the figure is built and steps as before: test_human holds the reference's figure, the ankled one and a fitted one on tight limits to hashes taken from main's module, bit for bit. The extra bones are made from the twelve as the feet are from the calves, where a person has them, and ride their parents through human_fit_shape; human_fit_bone puts one on a rig bone of its own. The upper arms hang from the clavicles and the chest from spine_02 (their frames re-read, so rest, cone and twist are what they were); each bone is filtered off the one it no longer hangs from or was set between. A twisting hinge is a spherical joint whose cone is the hinge's bend and whose sideways swing is locked by a new equality row, joint_solver.spherical_joint_lock_cone_minor (UE5's locked swing): an elliptical cone of 75 by 5 degrees chattered, because the ellipse's gap is a polar radius, not a distance, which is harmless at the hips' 2:1 and not at 15:1. The lock is opt-in and recorded as a new op (RECORDING_MINOR_VERSION 3); the spherical joint's data grows to 608 bytes (JOINT_DATA_BYTES), no joint's numbers change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #189
Part of #190
Two requests from ae3d's physical animation and networking, plus the Aether pin.
Landed
Next
Humanasanklesis. Bone indices fixed, absent bones have no body, the 12-body figure bit for bit as now.