Correct call for Human.UpdateDrawData function with new struct created in stack of functions#1716
Open
Correct call for Human.UpdateDrawData function with new struct created in stack of functions#1716
Conversation
wolfcomp
changed the title
github-actions
bot
added
the
breaking change
wolfcomp
force-pushed
the
graphics_drawdata_correction
branch
from
a3f64f4 to
f9e6f59
Compare
Contributor
Breaking ChangesMember exists in left but not in rightFFXIVClientStructs.FFXIV.Client.Graphics.Scene.Human.Delegates: 2UpdateDrawData: 2
SetupFromCharacterData: 2
|
| [FieldOffset(0x70), FixedSizeArray] internal FixedSizeArray2<EquipmentModelId> _glasses; | ||
|
|
||
| [MemberFunction("66 0F 6F 0D ?? ?? ?? ?? 0F 57 C0")] | ||
| public partial void Ctor(); |
Collaborator
There was a problem hiding this comment.
Does that not return this?
.text:000000014042DD0E 48 8B C1 mov rax, rcx
.text:000000014042DD11 C3 retnNot that it's used anywhere, but still.
Collaborator
Author
There was a problem hiding this comment.
Yes so is basically every other Ctor where ICreatable has also been used for the most part as with the MSVC compiler option all of them have the return of T*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.