[CLIENT-3106] Refactor work: convert Python expressions directly into C client as_exp_entry and avoid using intermediate expressions #852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctly instead of intermediate_exprs vector.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #852 +/- ##
==========================================
- Coverage 82.35% 0.00% -82.36%
==========================================
Files 99 43 -56
Lines 14379 8272 -6107
==========================================
- Hits 11842 0 -11842
- Misses 2537 8272 +5735 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…the other expressions passed as args
… the num of expression classes. We assume there is a one-to-one mapping between expression class instance and as_exp_entry.
juliannguyen4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ctly instead of intermediate_exprs vector.