Skip to content

Remove challenger magic numbers#976

Merged
Rotheem merged 3 commits intomainfrom
remove-challenger-magic-number
Mar 6, 2026
Merged

Remove challenger magic numbers#976
Rotheem merged 3 commits intomainfrom
remove-challenger-magic-number

Conversation

@Rotheem
Copy link
Member

@Rotheem Rotheem commented Mar 6, 2026

Description

Summary

Challenger data exporters had a faulty offset

Issues/PR dependencies

Issues to be resolved

Required PRs

Changes Made

  • removed magic numbers

Additional Notes

Classification

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 🔨 Refactor (non-breaking change that neither fixes a bug nor adds a feature)
  • 🔧 Infra CI/CD (changes to configs of workflows)
  • 💥 BREAKING CHANGE (fix or feature that require a new minimal version of the front-end)
  • 😶‍🌫️ No impact for the end-users

Impact & Scope

  • Core functionality changes
  • Single module changes
  • Multiple modules changes
  • Database migrations required
  • Other: ...

Testing

  • 1. Tested this locally
  • 2. Added/modified tests that pass the CI (or tested in a downstream fork)
  • 3. Tested in a deployed pre-prod
  • 0. Untestable (exceptionally), will be tested in prod directly

Documentation

  • Updated the docs accordingly :
  • " Docstrings
  • # Inline comments
  • No documentation needed

@Marc-Andrieu
Copy link
Member

closes #975

Copy link

@Azarta2Zygoto Azarta2Zygoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sound good to me

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.44%. Comparing base (ec737ba) to head (34f21c2).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tils/data_exporter/school_participants_exporter.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #976   +/-   ##
=======================================
  Coverage   84.44%   84.44%           
=======================================
  Files         205      205           
  Lines       14821    14821           
=======================================
  Hits        12516    12516           
  Misses       2305     2305           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Rotheem Rotheem merged commit 12b8866 into main Mar 6, 2026
7 checks passed
@Rotheem Rotheem deleted the remove-challenger-magic-number branch March 6, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants