feat: Ghost RUM Key Fix #1656
Closed
tkotthakota-adobe wants to merge 15 commits into
Closed
Conversation
Contributor
Author
|
Closing as duplicate to #1657 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://jira.corp.adobe.com/browse/SITES-46095
Problem sites: aashirvaad.com — CWV audits returned empty results because the RUM system had a domain key registered for www.aashirvaad.com but no actual data behind it. The resolver saw the key, assumed the www version was correct, and all audits queried the wrong domain.
What was fixed in the shared library (spacecat-shared-utils)
The shared wwwUrlResolver function now does a second check after finding a domain key: it calls the RUM bundler API to confirm there is real data behind the key. If the bundler returns an empty result, the key is treated as a ghost and the resolver moves on to try the original domain. Previously it trusted key existence alone.
What was fixed in the audit worker (spacecat-audit-worker)
The audit worker had its own full copy of the resolver logic that was diverging from the shared library. This was replaced with a thin wrapper that calls the shared library's resolver. On top of that, once the correct domain is confirmed, the wrapper now saves it as overrideBaseURL in the site's config — so future audits skip the probe entirely and go straight to the right domain.