feat: add allByExternalOwnerIdAndExternalSiteId type to SiteCollection#1655
Open
radhikagpt1208 wants to merge 1 commit into
Open
feat: add allByExternalOwnerIdAndExternalSiteId type to SiteCollection#1655radhikagpt1208 wants to merge 1 commit into
allByExternalOwnerIdAndExternalSiteId type to SiteCollection#1655radhikagpt1208 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing TypeScript type declaration for
allByExternalOwnerIdAndExternalSiteIdon theSiteCollectioninterface inspacecat-shared-data-access.The runtime method already exists — it is auto-generated from the site schema's external owner/site index (the same index that backs
findByExternalOwnerIdAndExternalSiteId). This change only declares the corresponding type so it mirrors the existingfindBy...declaration directly above it.What changed
src/models/site/index.d.ts— declareallByExternalOwnerIdAndExternalSiteId(externalOwnerId: string, externalSiteId: string): Promise<Site[]>onSiteCollection.Impact
Test plan
npm run lintpasses.findByExternalOwnerIdAndExternalSiteIdis already declared and that the pluralallBy...accessor is generated from the same index.