feat: Rewrite tsdiffer to rust and read the build's d.ts files#9935
Draft
snowystinger wants to merge 15 commits intomainfrom
Draft
feat: Rewrite tsdiffer to rust and read the build's d.ts files#9935snowystinger wants to merge 15 commits intomainfrom
snowystinger wants to merge 15 commits intomainfrom
Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
… from spurious large responses
|
Build successful! 🎉 |
…so only get-local errors when src/ is newer than dist/types/, while get-published accepts npm tarball contents as-is.
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
…ta directly in the build job
|
Build successful! 🎉 |
|
Build successful! 🎉 |
## API Changes
@react-spectrum/s2@react-spectrum/s2:ActionButton ActionButton {
...
id?: string
isDisabled?: boolean
+ isFoo?: boolean
isPending?: boolean
isQuiet?: boolean
...
}@react-spectrum/s2:ActionButtonProps ActionButtonProps {
...
id?: string
isDisabled?: boolean
+ isFoo?: boolean
isPending?: boolean
isQuiet?: boolean
...
}@react-spectrum/s2:Button Button {
...
id?: string
isDisabled?: boolean
+ isFoo?: boolean
isPending?: boolean
name?: string
...
}@react-spectrum/s2:ButtonProps ButtonProps {
...
id?: string
isDisabled?: boolean
+ isFoo?: boolean
isPending?: boolean
name?: string
...
}react-aria-componentsreact-aria-components:ButtonProps ButtonProps {
...
inert?: boolean | undefined
isDisabled?: boolean
+ isFoo?: boolean
isPending?: boolean
lang?: string | undefined
...
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
This has been completely written by Claude, I have done no code review yet, not even a peek. I'm doing some preliminary testing on it. The main thing was to start reading our *.d.ts files instead of running the build. This allows us not to publish
srcin our packages. We already don't publishsrcin any of our mono packages, so that's a problem pretty quickly.rewriting it to Rust has been more of the experimental side.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: