Skip to content

feat: Rewrite tsdiffer to rust and read the build's d.ts files#9935

Draft
snowystinger wants to merge 15 commits intomainfrom
rewrite-tsdiffer-to-rust
Draft

feat: Rewrite tsdiffer to rust and read the build's d.ts files#9935
snowystinger wants to merge 15 commits intomainfrom
rewrite-tsdiffer-to-rust

Conversation

@snowystinger
Copy link
Copy Markdown
Member

Closes

This has been completely written by Claude, I have done no code review yet, not even a peek. I'm doing some preliminary testing on it. The main thing was to start reading our *.d.ts files instead of running the build. This allows us not to publish src in our packages. We already don't publish src in any of our mono packages, so that's a problem pretty quickly.

rewriting it to Rust has been more of the experimental side.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@github-actions github-actions Bot added the RAC label Apr 16, 2026
@rspbot
Copy link
Copy Markdown

rspbot commented Apr 16, 2026

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 16, 2026

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 16, 2026

@github-actions github-actions Bot added the v3 label Apr 16, 2026
@rspbot
Copy link
Copy Markdown

rspbot commented Apr 16, 2026

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 16, 2026

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 16, 2026

…so only get-local errors when src/ is newer than

  dist/types/, while get-published accepts npm tarball contents as-is.
@rspbot
Copy link
Copy Markdown

rspbot commented Apr 17, 2026

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 17, 2026

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 17, 2026

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 17, 2026

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 17, 2026

@snowystinger snowystinger changed the title [DNM]: [WIP] feat: Rewrite tsdiffer to rust and read the build's d.ts files feat: Rewrite tsdiffer to rust and read the build's d.ts files Apr 17, 2026
@rspbot
Copy link
Copy Markdown

rspbot commented Apr 21, 2026

@rspbot
Copy link
Copy Markdown

rspbot commented Apr 21, 2026

## API Changes

@react-spectrum/s2

@react-spectrum/s2:ActionButton

 ActionButton {
   ...
   id?: string
   isDisabled?: boolean
+  isFoo?: boolean
   isPending?: boolean
   isQuiet?: boolean
   ...
 }

@react-spectrum/s2:ActionButtonProps

 ActionButtonProps {
   ...
   id?: string
   isDisabled?: boolean
+  isFoo?: boolean
   isPending?: boolean
   isQuiet?: boolean
   ...
 }

@react-spectrum/s2:Button

 Button {
   ...
   id?: string
   isDisabled?: boolean
+  isFoo?: boolean
   isPending?: boolean
   name?: string
   ...
 }

@react-spectrum/s2:ButtonProps

 ButtonProps {
   ...
   id?: string
   isDisabled?: boolean
+  isFoo?: boolean
   isPending?: boolean
   name?: string
   ...
 }

react-aria-components

react-aria-components:ButtonProps

 ButtonProps {
   ...
   inert?: boolean | undefined
   isDisabled?: boolean
+  isFoo?: boolean
   isPending?: boolean
   lang?: string | undefined
   ...
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants