Skip to content

fix(TextArea): fix empty S2 TextArea height jumping when overlays are open #9933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
reidbarber wants to merge 2 commits into
base: main
Choose a base branch
from
+22 −1
Open

fix(TextArea): fix empty S2 TextArea height jumping when overlays are open #9933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02a5126
fix(TextArea): fix empty S2 TextArea height jumping when overlays are…
reidbarber Apr 15, 2026
cf57c94
adjust fieldGroup to use `alignItems: 'start'`
reidbarber Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@react-spectrum/s2/src/TextField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export const TextArea = forwardRef(function TextArea(props: TextAreaProps, ref:
{...props}
ref={ref}
fieldGroupCss={style({
alignItems: 'baseline',
alignItems: 'start',
height: 'auto'
})}>
<TextAreaInput />
Expand Down
21 changes: 21 additions & 0 deletions packages/@react-spectrum/s2/stories/TextField.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,27 @@ export const TextAreaExample: StoryTextArea = {
}
};

export const TextAreaContextualHelpExample: StoryTextArea = {
render: (args) => (
<TextArea
{...args}
contextualHelp={
<ContextualHelp>
<Heading>Share your thoughts!</Heading>
<Content>
<Text>
Your comment will be visible to other users.
</Text>
</Content>
</ContextualHelp>
} />
),
args: {
label: 'Comment',
placeholder: 'Enter a comment'
}
};

export const CustomWidth: StoryTextField = {
render: (args) => <TextField {...args} styles={style({width: 384})} />,
args: {
Expand Down
Loading