fix: use attribute presence check for data-react-aria-top-layer in MutationObserver#9763
Open
lixiaoyan wants to merge 1 commit intoadobe:mainfrom
Open
fix: use attribute presence check for data-react-aria-top-layer in MutationObserver#9763lixiaoyan wants to merge 1 commit intoadobe:mainfrom
lixiaoyan wants to merge 1 commit intoadobe:mainfrom
Conversation
…tationObserver Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9762
✅ Pull Request Checklist:
📝 Test Instructions:
ariaHideOutsideon some target elementsdata-react-aria-top-layer=""(empty string) into the DOMaria-hidden="true"data-react-aria-top-layer="true"(exact string) was recognizedWhat changed
In
ariaHideOutside.ts, the initial DOM scan uses a CSS attribute presence selector ([data-react-aria-top-layer]) which matches the attribute regardless of value, but the MutationObserver previously checkednode.dataset.reactAriaTopLayer === 'true', requiring an exact match.This PR:
isAlwaysVisibleNodefunctiondata-react-aria-top-layercheck to!== undefined(attribute presence) to match the initial scan behaviordata-live-announcer === 'true'unchanged since it is always set to"true"inLiveAnnouncer.tsx🧢 Your Project:
N/A