Skip to content

fix: update ComboBox validate type for selection mode generic and null value #9742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lixiaoyan wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −2
Open

fix: update ComboBox validate type for selection mode generic and null value #9742

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f05674
fix: pass selection mode generic to ComboBox validate type
lixiaoyan Mar 5, 2026
902b343
fix: allow null value in ComboBox validate for single selection
lixiaoyan Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/@react-types/combobox/src/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import {
export type MenuTriggerAction = 'focus' | 'input' | 'manual';
export type SelectionMode = 'single' | 'multiple';
export type ValueType<M extends SelectionMode> = M extends 'single' ? Key | null : Key[];
type ValidationType<M extends SelectionMode> = M extends 'single' ? Key : Key[];
type ValidationType<M extends SelectionMode> = M extends 'single' ? Key | null : Key[];
Copy link
Member

@snowystinger snowystinger Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems incorrect, null should not be allowed. it's considered valid unless marked required in which case required validation will take care of it

if the assertion that allowsCustomValue can be called with null, then that seems like a bug


export interface ComboBoxValidationValue<M extends SelectionMode = 'single'> {
/**
Expand All @@ -50,7 +50,7 @@ export interface ComboBoxValidationValue<M extends SelectionMode = 'single'> {
inputValue: string
}

export interface ComboBoxProps<T, M extends SelectionMode = 'single'> extends CollectionBase<T>, InputBase, ValueBase<ValueType<M>>, TextInputBase, Validation<ComboBoxValidationValue>, FocusableProps<HTMLInputElement>, LabelableProps, HelpTextProps {
export interface ComboBoxProps<T, M extends SelectionMode = 'single'> extends CollectionBase<T>, InputBase, ValueBase<ValueType<M>>, TextInputBase, Validation<ComboBoxValidationValue<M>>, FocusableProps<HTMLInputElement>, LabelableProps, HelpTextProps {
/** The list of ComboBox items (uncontrolled). */
defaultItems?: Iterable<T>,
/** The list of ComboBox items (controlled). */
Expand Down