Skip to content

fix: prevent hover state from showing when ToggleButtonGroup is disabled #9449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
reidbarber merged 1 commit into from
Jan 8, 2026
Merged

fix: prevent hover state from showing when ToggleButtonGroup is disabled #9449

reidbarber merged 1 commit into from
Jan 8, 2026

Conversation

@chirokas
Copy link
Contributor

@chirokas chirokas commented Jan 8, 2026

Closes #9445

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@chirokas chirokas marked this pull request as ready for review January 8, 2026 11:38
reidbarber
reidbarber approved these changes Jan 8, 2026
View reviewed changes
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@reidbarber reidbarber added this pull request to the merge queue Jan 8, 2026
Merged via the queue into adobe:main with commit cff4670 Jan 8, 2026
31 checks passed
@chirokas chirokas deleted the issue-9445 branch January 9, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbarber reidbarber reidbarber approved these changes

@yihuiliao yihuiliao yihuiliao approved these changes

Assignees

No one assigned

Labels

ready for review small review Easy to review PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

data-hovered attribute is added to ToggleButton when parent ToggleButtonGroup is disabled

3 participants

@chirokas @reidbarber @yihuiliao