-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(docs): update tanstack start routing setup #9396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+18
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stunaz
previously requested changes
Dec 31, 2025
packages/dev/s2-docs/src/routers.mdx
Outdated
| useHref={href => router.buildLocation(href).href}> | ||
| navigate={(href, opts) => { | ||
| if (typeof href === "string") return; | ||
| router.navigate({ ...href, ...opts }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return router.navigate({ ...href, ...opts });
snowystinger
reviewed
Jan 6, 2026
snowystinger
reviewed
Jan 7, 2026
reidbarber
approved these changes
Jan 7, 2026
snowystinger
approved these changes
Jan 7, 2026
devongovett
reviewed
Jan 8, 2026
| navigate: (href, opts) => router.navigate({...href, ...opts}), | ||
| useHref: href => router.buildLocation(href).href | ||
| navigate: (href, opts) => { | ||
| if (typeof href === "string") return; |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this case actually occur? Wouldn't that mean nothing happens when you click the link?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Tanstack Start routing setup doesn't handle external links properly. When passing a string
href(e.g.,<MenuItem href="https://github.com">), the router'snavigateandbuildLocationmethods fail with:Added type guards to handle string hrefs separately: