docs: Fix plant images #9208
Merged
docs: Fix plant images #9208
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
commented
Nov 18, 2025
| @@ -1,5 +1,5 @@ | |||
| // @ts-ignore | |||
| import assets from 'url:../pages/**/*.{png,jpg,svg}'; | |||
| import assets from 'url:../pages/**/*.{png,jpg,svg}' with {env: 'react-client'}; | |||
Member
Author
There was a problem hiding this comment.
Ensuring we only get one copy of the images, not one for the server environment and one for the client environment.
Member
There was a problem hiding this comment.
I can't find any documentation on this import, is it specific to parcel or one of our pipelines?
Member
Author
There was a problem hiding this comment.
yeah this is a secret parcel syntax. ideally images would not be specific to an environment in the first place but that will require an upstream change. this is a quick workaround.
|
Build successful! 🎉 |
snowystinger
approved these changes
Nov 18, 2025
| @@ -1,5 +1,5 @@ | |||
| // @ts-ignore | |||
| import assets from 'url:../pages/**/*.{png,jpg,svg}'; | |||
| import assets from 'url:../pages/**/*.{png,jpg,svg}' with {env: 'react-client'}; | |||
Member
There was a problem hiding this comment.
I can't find any documentation on this import, is it specific to parcel or one of our pipelines?
reidbarber
approved these changes
Nov 18, 2025
devongovett
added a commit
that referenced
this pull request
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Filterable CRUD Table example in production builds. This was broken in #9135 due to
plants.tsbeing included in the downloadable ZIP. Parcel content hashes URLs by default, but this changes the length of the string which messes up the RSC payload. This changes those plant images to be non-content hashed, which should be fine since they should never change.