fix: allow browser back/forward navigation in Tabs (Cmd+Left/Right on Mac, Alt+Left/Right on Windows)#10315
Open
UsmanKhursheed06 wants to merge 2 commits into
Open
Conversation
… Mac, Alt+Left/Right on Windows) When users press Cmd+Left/Right (Mac) or Alt+Left/Right (Windows/Linux) to navigate browser history, the Tabs component was capturing these keystrokes and switching tabs instead of letting the browser handle back/forward navigation. Added keyboard shortcut handlers in useTabList that explicitly allow propagation for these browser navigation key combinations, while preserving normal tab navigation with unmodified arrow keys. Fixes adobe#9648
snowystinger
reviewed
Jul 8, 2026
| await menu.close(); | ||
| }); | ||
|
|
||
| it('allows browser back/forward navigation (Meta+ArrowLeft/Right on Mac, Alt+ArrowLeft/Right on Windows)', async () => { |
Member
There was a problem hiding this comment.
This test is passing without your change. It was likely fixed since the last release with our new useKeyboard apis and will go out in our next release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When users press Cmd+Left/Right (Mac) or Alt+Left/Right (Windows/Linux) to navigate browser history, the Tabs component was capturing these keystrokes and switching tabs instead of letting the browser handle back/forward navigation.
Changes
Testing
Added comprehensive test in verifying:
All existing tests pass (50/50).