Skip to content

fix: checkbox in cardview and radio and switch#10012

Open
snowystinger wants to merge 1 commit intomainfrom
fix-checkbox-in-cardview
Open

fix: checkbox in cardview and radio and switch#10012
snowystinger wants to merge 1 commit intomainfrom
fix-checkbox-in-cardview

Conversation

@snowystinger
Copy link
Copy Markdown
Member

@snowystinger snowystinger commented May 5, 2026

Closes

Found in chromatic. We can't use implicit columns because we're in a subgrid and subgrids can't create an implicit track.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@github-actions github-actions Bot added the S2 label May 5, 2026
@rspbot
Copy link
Copy Markdown

rspbot commented May 5, 2026

Comment on lines +178 to +181
gridTemplateColumns: {
default: ['max-content', '1fr'],
isNoVisibleLabel: ['max-content']
},
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nvm I forgot this was intentional from https://github.com/adobe/react-spectrum/pull/9877/changes#diff-43aff8e2be0a942e4e38e2dfe84fe8d8037a5408d5b8a135f0a22042941d8e2fR103. We'll probably need to call this out in the next release since there may be people who were relying on the previous behavior who will now need to constrain the width of their group

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants