Repository navigation
IOEXT-2184: fix: set Parcel mode from NODE_ENV instead of always using development (CEXT-6815) - #248
Merged
sandeep-paliwal merged 2 commits intoOct 8, 2026
Conversation
8 of 10 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
Thanks @iivvaannxx . Code changes look good. |
Contributor
Author
|
@sandeep-paliwal I recorded a video better :) The problem that this caused to us is that when Parcel was building a
Screen.Recording.2026-10-05.at.18.09.57.mov |
Contributor
Author
|
@sandeep-paliwal @santosh-chamoli please merge when you can, I don't have permissions to do it :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Parcel defaults
modetodevelopmentwhen it isn't passed in, sobundleandbuildWebalways produced development builds, even withNODE_ENV=production.bundleandbuildWebnow setmodefromNODE_ENV, usingproductiononly whenNODE_ENV=production. They passenv.NODE_ENVto Parcel. When the caller doesn't setshouldOptimize, it defaults totruein production. Callers can still overridemode,envanddefaultTargetOptionsexplicitly.The e2e script regex now also matches unquoted
srcattributes, which appear once Parcel minifies the HTML in production.Related Issue
IOEXT-2184 (blocks CEXT-6815)
Companion PR adobe/aio-cli-plugin-app#942 reloads
.envafter pre-app hooks, so aNODE_ENVset there reaches this build.Motivation and Context
Production deploys shipped development bundles with dev-only code paths and no minification.
How Has This Been Tested?
npm test: 135 tests pass, including new tests for production mode fromNODE_ENVand for explicit overrides.eslint src test e2eis clean.Types of changes
Checklist: