fix: build jsdocs via frontend-maven-plugin instead of exec-maven-plugin - #1981
Merged
Conversation
Accessibility Violations Found
|
1 similar comment
Accessibility Violations Found
|
exec-maven-plugin invoked node_modules/.bin/jsdoc directly, which requires a global node binary on PATH via its #!/usr/bin/env shebang. In build environments without a global Node install (e.g. Cloud Manager), this fails with exit 127: "/usr/bin/env: 'node': No such file or directory". Route the jsdoc generation through frontend-maven-plugin's npm goal instead, which correctly uses the locally-installed node/npm it manages, matching the pattern already used by other modules in this repo (e.g. ui.frontend).
rismehta
force-pushed
the
fix/jsdocs-cloud-manager-build-node-path
branch
from
September 9, 2026 06:43
f7aa727 to
3653a18
Compare
Accessibility Violations Found
|
Accessibility Violations Found
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
jsdocs/pom.xmlusedexec-maven-pluginto invokenode_modules/.bin/jsdocdirectly. That script has a#!/usr/bin/env nodeshebang, which requires a globalnodebinary onPATH. Build environments that don't have Node installed globally (e.g. Adobe Cloud Manager's build container, which only has the Node thatfrontend-maven-plugininstalls locally intojsdocs/node/) fail with:This fix routes the jsdoc generation through
frontend-maven-plugin's ownnpmgoal (npm run jsdoc, added as a script inpackage.json), which correctly resolves and prepends its own locally-installed Node/npm toPATHfor the child process. This matches the pattern already used by other modules in this repo (e.g.ui.frontend/pom.xml) and removes the now-unneeded Windows/unixscript.fileprofiles.Related Issue
Found while diagnosing a downstream Cloud Manager build failure that vendors this module.
Motivation and Context
Without this fix, any build environment lacking a global
nodebinary onPATHfails to build thecore-forms-components-af-jsapimodule, even though the module already manages its own Node install viafrontend-maven-plugin.How Has This Been Tested?
Ran
mvn clean packageinjsdocs/standalone — build succeeds and the jsdoc jar/HTML output is generated correctly, both with and without a global Node onPATH.Types of changes
Checklist: