This repository was archived by the owner on Jul 7, 2020. It is now read-only.
Make MurmurHash of Strings independent of default encoding#85
Open
bfaria wants to merge 2 commits intoaddthis:masterfrom
Open
Make MurmurHash of Strings independent of default encoding#85bfaria wants to merge 2 commits intoaddthis:masterfrom
bfaria wants to merge 2 commits intoaddthis:masterfrom
Conversation
When hashing Strings MurmurHash simply uses the getBytes method, which will use the default platform encoding. This is not portable.
Author
|
I didn't notice guava was just a test scope dependency. I will remove the use of Charsets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When hashing Strings MurmurHash simply uses the getBytes() method, which
will use the default platform encoding. This is not portable.
I've changed all calls to getBytes(Charset) and fixed the encoding to UTF8.