[codex] Unify package targeting resolution - #6220
Draft
bokelley wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6132.
What changed
targeting_overlay, with selected and default modes.targeting_resolutionfor complete seller-applied targeting.targeting_resolution.demographicswhile preserving exact requested/applied predicates.update_placements,PLACEMENT_SELECTION_INVALID, lifecycle documentation, compliance paths, and shared SDK vectors.Why
Placement selection, property targeting, and demographic resolution previously used inconsistent package surfaces even though they are evaluated together. The unified model separates complete buyer intent from complete seller-applied state and requires sellers to reject invalid or non-equivalent intersections instead of silently dropping targeting.
Impact
Buyers send all targeting intent through
package.targeting_overlay. Package responses return the requested overlay plustargeting_resolution; placement-targeted packages include resolved placements and the properties and collections where each can run.Validation
node tests/schema-validation.test.cjsnode tests/composed-schema-validation.test.cjsnode --test tests/placement-selection-schema.test.cjsnode --test tests/demographic-targeting.test.cjsnode --test tests/media-buy-targeting-overlay-vectors.test.cjsnode scripts/build-schemas.cjsnode scripts/build-compliance.cjsTypeScript typechecking was unavailable because this workspace has no local dependency installation and its npm version does not satisfy the repository's
npm@10.9.4requirement.