Skip to content

fix(release): compare normalized prerelease versions #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bokelley merged 1 commit into from
Aug 5, 2026
Merged

fix(release): compare normalized prerelease versions #1015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/test_release_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@
import re
from pathlib import Path

from scripts.normalize_pyproject_prerelease import pep440_prerelease

ROOT = Path(__file__).parent.parent


def test_worktree_version_matches_last_release_manifest() -> None:
def test_worktree_version_matches_normalized_release_manifest() -> None:
pyproject = (ROOT / "pyproject.toml").read_text()
project_section = re.search(
r'^\[project\]\s*$.*?^version\s*=\s*"([^"]+)"',
Expand All @@ -18,7 +20,7 @@ def test_worktree_version_matches_last_release_manifest() -> None:
)
assert project_section is not None
manifest = json.loads((ROOT / ".release-please-manifest.json").read_text())
assert project_section.group(1) == manifest["."]
assert project_section.group(1) == pep440_prerelease(manifest["."])


def test_release_please_targets_v7_rc_from_breaking_commit() -> None:
Expand Down
Loading