Prevent ble delay on deep sleep wake; add CIRCUITPY_BLE_WORKFLOW; doc editing#11123
Merged
tannewt merged 5 commits intoJul 16, 2026
Merged
Conversation
The mcu_reset_reason_t members used a bare RESET_REASON_ prefix. Several port SDKs also use RESET_REASON_* names for their own purposes: atmel-samd ASF4 reset_reason, esp-idf soc_reset_reason_t, Nordic softdevice, Silabs Gecko SDK, NXP SCFW. Fortunately there were no conflicts, but this could have caused either name conflicts or human confusion about which name to use. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dhalbert
force-pushed
the
prevent-ble-delay-on-deep-sleep-wake
branch
2 times, most recently
from
July 15, 2026 02:41
150c078 to
2cef925
Compare
…nups; doc editing
dhalbert
force-pushed
the
prevent-ble-delay-on-deep-sleep-wake
branch
from
July 15, 2026 02:58
2cef925 to
480b994
Compare
…RCUITPY_BLE_SERIAL_SERVICE
tannewt
requested changes
Jul 15, 2026
tannewt
left a comment
tannewt
left a comment
Member
There was a problem hiding this comment.
Looks fine. I'd rather it default to on though because it'll be a bit more discoverable that way and not change the default behavior.
dhalbert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Boot time regression from 9.2.x to 10 when exiting deep sleep (esp32-s3) #10934
When waking from true deep sleep, do not do BLE workflow blue-flash delay. BLE workflow will still be entered, but you can't initiate BLE workflow the first time from a deep sleep wake. The is the actual Boot time regression from 9.2.x to 10 when exiting deep sleep (esp32-s3) #10934 fix.
Disable BLE workflow by default. This is a deliberate incompatibility with previous versions, which enabled BLE workflow by default.A new setting,CIRCUITPY_BLE_WORKFLOW(defaultfalse) was added tosettings.toml. The blue-flash bonding delay is not present unless this setting istrue.If
CIRCUITPY_BLE_WORKFLOWisfalse,supervisor.runtime.ble_workflowhas no effect; documented this.The justification for the change in the default is that the web workflow is also not enabled by default: you must setCIRCUITPY_WEB_API_PASSWORD. In addition, the BLE workflow is rare. It also is not so reliable right now, but that is not a primary reason.Added documentation for
CIRCUITPY_BLE_WORKFLOWto the Environment Variables (settings.toml) documentation.Labeled all the supported keys in the documentation with their data types: string, integer, float, bool.
Renamed all the
RESET_REASON_*enums inshared-bindings/microcontroller/ResetReason.htoMCU_RESET_REASON_*. and changed their uses. The motivation is that several port SDKs happen to define their ownRESET_REASON_values. Fortunately there were no clashes, but it's clearer and safer to separate the values with a prefix.Did some minor code formatting and commenting in
supervisor/shared/bluetooth/bluetooth.c.Renamed
CIRCUITPY_SERIAL_BLEtoCIRCUITPY_BLE_SERIAL_SERVICE, to matchCIRCUITPY_BLE_FILE_SERVICE.Turned on
CIRCUITPY_SETTINGS_TOMLfor all nRF boards.Changed the checks for the kind of MCU_RESET_REASON from negative checks to positive checks in various
supervisor/sharedcode, to make the reasoning clearer.This is a typical human PR; I only used an LLM to editing effort for some renaming.
I will update the BLE Guide pages to reflect the BLE workflow changes as needed.