Skip to content

Allow nil values in array #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow nil values in array #1657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
771827c
Allow nil values in array
Tobias-Knudsen Nov 11, 2025
a3cbff0
Add spec
Tobias-Knudsen Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ransack/search.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def initialize(object, params = {}, options = {})
if params.is_a? Hash
params = params.dup
params = params.transform_values { |v| v.is_a?(String) && strip_whitespace ? v.strip : v }
params.delete_if { |k, v| [*v].all?{ |i| i.blank? && i != false } }
params.delete_if { |k, v| [*v].all?{ |i| i.blank? && i != false && !i.nil? } }
else
params = {}
end
Expand Down
6 changes: 6 additions & 0 deletions spec/ransack/search_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,12 @@ module Ransack
Search.new(Person, name_eq_any: ['foobar'])
end

it 'keeps conditions with a nil value in an array before building' do
expect_any_instance_of(Search).to receive(:build)
.with({ 'name_in' => [nil] })
Search.new(Person, name_in: [nil])
end

it 'does not raise exception for string :params argument' do
expect { Search.new(Person, '') }.not_to raise_error
end
Expand Down
Loading