fix: make password field optional for creating data source#819
Open
LordofAvernus wants to merge 1 commit intomainfrom
Open
fix: make password field optional for creating data source#819LordofAvernus wants to merge 1 commit intomainfrom
LordofAvernus wants to merge 1 commit intomainfrom
Conversation
Remove the required validation on Password field when creating a new data source. Some databases like TiDB use empty password for root user by default. The password remains required only during update when the 'need update password' toggle is enabled. Refs #2738
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes https://github.com/actiontech/sqle-ee/issues/2738