fix(dms-kit): add defensive type check in useTableRequestError#818
Open
LordofAvernus wants to merge 1 commit intomainfrom
Open
fix(dms-kit): add defensive type check in useTableRequestError#818LordofAvernus wants to merge 1 commit intomainfrom
LordofAvernus wants to merge 1 commit intomainfrom
Conversation
…vent crash on non-JSON response When backend API returns HTML instead of JSON (e.g., unregistered route falling through to static file middleware), response.data is a string. Using 'in' operator on a string throws TypeError. Add typeof check before accessing response.data properties, and set error message instead of crashing. #787
Coverage report
Test suite run success3643 tests passing in 810 suites. Report generated by 🧪jest coverage report action from f724804 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useTableRequestErrorhook to prevent crash when API returns non-JSON responseRelated: https://github.com/actiontech/dms-ee/issues/787