Fix null field for resource metadata fields in experimental chart#4419
Open
nikola-jokic wants to merge 2 commits intomasterfrom
Open
Fix null field for resource metadata fields in experimental chart#4419nikola-jokic wants to merge 2 commits intomasterfrom
nikola-jokic wants to merge 2 commits intomasterfrom
Conversation
Wrap all AutoscalingRunnerSet *ResourceMeta spec fields with guards that check for non-empty labels OR annotations before rendering the wrapper key. This prevents empty YAML objects in the rendered output when metadata is not provided. Affected fields: - autoscalingListener - listenerServiceAccountMetadata - listenerRoleMetadata - listenerRoleBindingMetadata - listenerConfigSecretMetadata - ephemeralRunnerSetMetadata - ephemeralRunnerMetadata - ephemeralRunnerConfigSecretMetadata
…source meta rendering
nikola-jokic
added
the
gha-runner-scale-set
nikola-jokic
requested review from
a team,
Steve-Glass and
rentziass
as code owners
Contributor
|
Hello! Thank you for your contribution. Please review our contribution guidelines to understand the project's testing and code conventions. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a Helm rendering issue in the gha-runner-scale-set-experimental chart where empty ResourceMeta blocks could be emitted as YAML null fields in the AutoscalingRunnerSet spec, by omitting those spec fields unless labels or annotations are actually populated.
Changes:
- Update
autoscalingrunnserset.yamlto conditionally render ResourceMeta spec blocks only whenlabelsorannotationsare non-empty (preventingkey: nulloutput). - Add a comprehensive helm-unittest suite to assert omission by default and correct rendering when labels/annotations are provided across all supported ResourceMeta fields.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/gha-runner-scale-set-experimental/templates/autoscalingrunnserset.yaml | Prevents rendering empty ResourceMeta spec fields by gating output on non-empty labels/annotations. |
| charts/gha-runner-scale-set-experimental/tests/autoscaling_runner_set_resource_meta_omission_test.yaml | Adds test coverage to ensure ResourceMeta spec fields are omitted when empty and present when populated. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.