Tighten ioredis range to ^5.10.1 to exclude broken 5.10.0#1288
Merged
evantahler merged 1 commit intomainfrom Apr 22, 2026
Merged
Tighten ioredis range to ^5.10.1 to exclude broken 5.10.0#1288evantahler merged 1 commit intomainfrom
evantahler merged 1 commit intomainfrom
Conversation
Closes #1287. 5.10.0 introduced a nominal-type regression on AbstractConnector that breaks downstream TypeScript consumers (e.g. keryx) when two ioredis copies coexist in the tree. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1287. Bumps the
ioredisdependency range from^5.9.1to^5.10.1so that the broken5.10.0release can no longer be selected.ioredis@5.10.0introduced a nominal-typing regression onAbstractConnectorthat causes TypeScript consumers (e.g. keryx) to fail when two ioredis copies end up coexisting in the dependency tree — one pulled via node-resque's loose range, one pinned tighter by the app. Narrowing our range to^5.10.1lets package managers dedupe and fixes the downstream type error without any code change in consumers.Test plan
npm testpasses locally against real Redis🤖 Generated with Claude Code