Open
Conversation
Fixes: - `is_subnet_of` was broken if the supernet was not the network address. - Display now prints the network ip and not the initial ip. - Tests that were asserting against `.ip()`. Adds: - A regression test.
Owner
|
Sorry, it took me a while to reply, and thanks for the PR. I still have to figure out a good workflow of deprecating APIs and removing them eventually. Hence I am not a fan of changing the behaviour of |
Author
|
@achanda I understand! I'll update my PR with just the fix for |
Contributor
|
Probably superseded by #177. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
is_subnet_ofwas broken if the supernet was not the network address.IpNetwork..ip().Adds:
If there is no plans on breaking backwards compatibility, the
ip()method should be re-introduced in my changes. Also, ifipis not kept, there would be no need fornetwork()to compute the network address anymore as the arithmetic can be done in the constructor and the resulting ip stored in the struct, discarding the originalIpAddr.