Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions agent-notes/improve-syslog-utc.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Goal

Make remote log timestamps ending in Z represent UTC.

# State

Set only the syslog formatter's converter to time.gmtime. This PR is independently based on integrated master. Local formatting, remote transport and application settings remain unchanged.

# Decisions and why

logging.Formatter defaults to local time. Its existing converter setting provides UTC without changing any global formatter behavior or requiring another open PR.

# Surprises

No inspected application manifest enabled remote logging. This correction does not establish server receipt.

# Next step

Read the corrected PR's existing package checks. No merge or release.
2 changes: 2 additions & 0 deletions logger_setup/logger_setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import sys
import os
import traceback
import time

from . import crashlogger

Expand Down Expand Up @@ -78,6 +79,7 @@ def setup_logging(
)
remote_date_format = "%Y-%m-%dT%H:%M:%SZ"
remote_formatter = logging.Formatter(remote_format, datefmt=remote_date_format)
remote_formatter.converter = time.gmtime
remote_handler = create_handler(
filename=None,
level=remote_level,
Expand Down
Loading