Repository navigation
Write application log files as UTF-8 - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Write application log files as UTF-8 on every supported platform.
State
File handlers explicitly request UTF-8. Console handlers and file write mode are unchanged. The existing package/configuration CI runs on this PR; it does not run application logging scenarios.
Decisions and why
QRead, QFeed and QCast log externally supplied titles. Their content must not depend on the Windows locale's default encoding. Use FileHandler's existing encoding argument, available on the consumers' Python 3.8 baseline.
Surprises
The existing helper's filename branch is the only file-handler construction site.
Next step
Read the published PR's checks. Merge and release are outside this task.